[PATCH] D55028: [gn build] Add template for running llvm-tblgen and use it to add build file for llvm/lib/IR.

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 29 14:06:00 PST 2018


phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/utils/gn/secondary/llvm/utils/TableGen/tablegen.gni:37
+  action(target_name) {
+    forward_variables_from(invoker, [ "visibility" ])
+
----------------
thakis wrote:
> phosek wrote:
> > You should probably forward `testonly` as well`.
> I haven't needed it yet -- are you aware of any test-only tblgen invocations?
Nope, but it's a general pattern to always forward `visibility` and `testonly`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55028/new/

https://reviews.llvm.org/D55028





More information about the llvm-commits mailing list