[llvm] r347916 - [obj2yaml] [COFF] Write RVA instead of VA for sections, fix roundtripping executables

[Martin Storsjo via llvm-commits]

Author: mstorsjo
Date: Thu Nov 29 12:53:57 2018
New Revision: 347916

URL: http://llvm.org/viewvc/llvm-project?rev=347916&view=rev
Log:
[obj2yaml] [COFF] Write RVA instead of VA for sections, fix roundtripping executables

yaml2obj writes the yaml value as is to the output file.

Differential Revision: https://reviews.llvm.org/D54965

Modified:
    llvm/trunk/test/tools/yaml2obj/coff-arm64.yaml
    llvm/trunk/tools/obj2yaml/coff2yaml.cpp

Modified: llvm/trunk/test/tools/yaml2obj/coff-arm64.yaml
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/yaml2obj/coff-arm64.yaml?rev=347916&r1=347915&r2=347916&view=diff
==============================================================================
--- llvm/trunk/test/tools/yaml2obj/coff-arm64.yaml (original)
+++ llvm/trunk/test/tools/yaml2obj/coff-arm64.yaml Thu Nov 29 12:53:57 2018
@@ -1,8 +1,13 @@
 # RUN: yaml2obj %s -o %t
 # RUN: llvm-readobj -file-headers %t | FileCheck %s
+# RUN: obj2yaml %t | FileCheck %s --check-prefix=ROUNDTRIP
 
 # CHECK: OptionalHeaderSize: 240
 
+# ROUNDTRIP: VirtualAddress:  4096
+# ROUNDTRIP: VirtualAddress:  8192
+# ROUNDTRIP: VirtualAddress:  12288
+
 --- !COFF
 OptionalHeader:  
   AddressOfEntryPoint: 4096
@@ -72,17 +77,17 @@ header:
 sections:        
   - Name:            .text
     Characteristics: [ IMAGE_SCN_CNT_CODE, IMAGE_SCN_MEM_EXECUTE, IMAGE_SCN_MEM_READ ]
-    VirtualAddress:  1073745920
+    VirtualAddress:  4096
     VirtualSize:     4
     SectionData:     C0035FD6
   - Name:            .rdata
     Characteristics: [ IMAGE_SCN_CNT_INITIALIZED_DATA, IMAGE_SCN_MEM_READ ]
-    VirtualAddress:  1073750016
+    VirtualAddress:  8192
     VirtualSize:     12
     SectionData:     0100400800000000E4E3E3E3
   - Name:            .pdata
     Characteristics: [ IMAGE_SCN_CNT_INITIALIZED_DATA, IMAGE_SCN_MEM_READ ]
-    VirtualAddress:  1073754112
+    VirtualAddress:  12288
     VirtualSize:     8
     SectionData:     '0010000000200000'
 symbols:         []

Modified: llvm/trunk/tools/obj2yaml/coff2yaml.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/obj2yaml/coff2yaml.cpp?rev=347916&r1=347915&r2=347916&view=diff
==============================================================================
--- llvm/trunk/tools/obj2yaml/coff2yaml.cpp (original)
+++ llvm/trunk/tools/obj2yaml/coff2yaml.cpp Thu Nov 29 12:53:57 2018
@@ -147,7 +147,7 @@ void COFFDumper::dumpSections(unsigned N
     COFFYAML::Section NewYAMLSection;
     ObjSection.getName(NewYAMLSection.Name);
     NewYAMLSection.Header.Characteristics = COFFSection->Characteristics;
-    NewYAMLSection.Header.VirtualAddress = ObjSection.getAddress();
+    NewYAMLSection.Header.VirtualAddress = COFFSection->VirtualAddress;
     NewYAMLSection.Header.VirtualSize = COFFSection->VirtualSize;
     NewYAMLSection.Header.NumberOfLineNumbers =
         COFFSection->NumberOfLinenumbers;