[PATCH] D54904: Introduce `AddressSpaceView` template parameter to `SizeClassAllocator32`, `FlatByteMap`, and `TwoLevelByteMap`.

[Dan Liew via Phabricator via llvm-commits]

delcypher marked 4 inline comments as done.
delcypher added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_allocator_internal.h:50
+template <typename AddressSpaceView>
+using PrimaryInternalAllocatorT = SizeClassAllocator32<AP32<AddressSpaceView>>;
+using PrimaryInternalAllocator =
----------------
delcypher wrote:
> kubamracek wrote:
> > Can we unify the naming convention of adding "T" and "Ty" suffix to types? Do we need both?
> Sure they can be unified. However before I go for a mass rename, do we want a different name? The `T` suffix was a placeholder for until I came up with a better name. Given that these types always take a single template parameter that is an `AddressSpaceView` make the suffix should reflect that. For example we could make the suffix be `ASVT` (Address Space View Type) rather than `T`. What do you think?
@kubamracek I went with `ASVT` as the suffix for types that take a single `AddressSpaceView` template parameter. The only place I didn't make the change is the actually allocator parameter struct type names (e.g. AP32) so that the name is kept short.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54904/new/

https://reviews.llvm.org/D54904