[PATCH] D50632: [LLD][ELF] - Simplify TLS LD handling code.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 29 11:16:29 PST 2018


ruiu added inline comments.


================
Comment at: ELF/Arch/PPC64.cpp:742-743
+  if (Expr == R_RELAX_TLS_LD_TO_LE) {
+    if (Type == R_PPC64_GOT_DTPREL16_HA || Type == R_PPC64_GOT_DTPREL16_LO_DS ||
+        Type == R_PPC64_GOT_DTPREL16_DS || Type == R_PPC64_GOT_DTPREL16_HI)
+      return Expr;
----------------
The old code doesn't say anything about these relocations, but your new code contains code for these relocations. Where did they come from? What is special about them?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50632/new/

https://reviews.llvm.org/D50632





More information about the llvm-commits mailing list