[PATCH] D45862: [InstCombine] Remove decanonicalizing transforms of selects

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: test/Transforms/InstCombine/unrecognized_three-way-comparison.ll:11-13
 ; TODO: We can prove that if %x s> %c then %x != c, so there should be no actual
 ;       calculations in callfoo block. @foo can be invoked with 1. We only do it
 ;       for constants that are not 0 currently while it could be generalized.
----------------
Not sure exactly where the logic hole is that caused this, but I moved a fold to InstSimplify in:
rL347896
...and now we get this case and the similar 'compare_against_arbitrary_value_type_mismatch' test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D45862/new/

https://reviews.llvm.org/D45862