[PATCH] D50977: [TableGen] Examine entire subreg compositions to detect ambiguity

Thu Nov 29 07:16:57 PST 2018

bjope added a comment.

Got a feeling that I'm the one who has been questioning this solution. And I guess I also kind of blocked the progress in D54962 <https://reviews.llvm.org/D54962>.
Anyway, I haven't really got any better alternative right now (at least not that is easy to implement).

If we land this we at least get rid of what seems to be "false" warnings for SystemZRegisterInfo.td.
And then:

- If we find a SystemZ internal solution (continuation of D54962 <https://reviews.llvm.org/D54962>) we can always revert this later when it isn't needed any longer.
- If we find a better way to deal with syntesized/composed subregisters etc in tablegen, then we can work on that (in peace) without rushing anything.

Does that sound good to you @kparzysz and @uweigand ?
(If you agree, then I can accept this solution for now.)

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50977/new/

https://reviews.llvm.org/D50977