[PATCH] D55017: [SLP]PR39774: Update references of the replaced external instructions.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 29 06:53:40 PST 2018


ABataev added a comment.

In D55017#1312206 <https://reviews.llvm.org/D55017#1312206>, @spatel wrote:

> Again, we'll need another reviewer to approve this...but let me check my understanding: I think this bug is independent of the fix from D54955 <https://reviews.llvm.org/D54955>? So is it possible to come up with a smaller test case to demonstrate that or would we always hit the previous ReductionRoot problem first?


It is not independent, it is the second part of the same bugfix. The first patch fixed the cost model, but did not include the reference update. Anyway, I'll just add another `RUN` directive with this new parameters and will keep the original test as is.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55017/new/

https://reviews.llvm.org/D55017





More information about the llvm-commits mailing list