[PATCH] D55020: [llvm-rc] Support EXSTYLE statement.
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 29 04:03:09 PST 2018
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
LGTM
However, I can't commit it as is, as the diff for test/tools/llvm-rc/Inputs/tag-dialog-headers.rc is missing, as it's treated as binary. I'm not sure exactly why we have that there, but you can e.g. remove the relevant line from .gitattributes before diffing, to get that file included in the diff.
================
Comment at: tools/llvm-rc/ResourceVisitor.h:30
class StyleStmt;
+class ExStyleStmt;
class VersionStmt;
----------------
This one is still unordered, but I could change that before committing.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55020/new/
https://reviews.llvm.org/D55020
More information about the llvm-commits
mailing list