[PATCH] D54439: CMake: Make most target symbols hidden by default

[Michael Platings via Phabricator via llvm-commits]

michaelplatings added a comment.

"LLVM_EXPORT" seems like an overly generic name.  Maybe a variation on "LLVM_LIBRARY_VISIBILITY" would be more fitting?

Another contender for the "LLVM_EXPORT" name that I'd like to see some day is a macro that exports symbols from Windows DLLs using `__declspec( dllexport )` and then we can get rid of this: D18826 <https://reviews.llvm.org/D18826>

A comment should be added in Compiler.h to document the macro.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54439/new/

https://reviews.llvm.org/D54439