[PATCH] D55030: [AMDGPU] Fold brcond (setcc zext(i1 x), 1, ne) -> brcond x

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 28 17:08:25 PST 2018


rampitec marked an inline comment as done.
rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:8664
+  if (OrigCC.getValueType() != MVT::i1)
+    return SDValue();
+
----------------
mareko wrote:
> How do you know OrigCC is setcc? It could also be any bitwise op.
I do not need to kbow it, it can be anything producing i1. An i1 value will become sreg64 and will be directly used. In fact in the testcase it is not setcc, it is CopyFromReg.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55030/new/

https://reviews.llvm.org/D55030





More information about the llvm-commits mailing list