[PATCH] D55030: [AMDGPU] Fold brcond (setcc zext(i1 x), 1, ne) -> brcond x

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 28 14:37:41 PST 2018


arsenm added a comment.

Should this be a generic combine?



================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:8643
+  if (CC.getOpcode() != ISD::SETCC ||
+      CC.getOperand(0)->getOpcode() != ISD::ZERO_EXTEND ||
+      !isa<ConstantSDNode>(CC.getOperand(1)))
----------------
sext should also be OK


================
Comment at: test/CodeGen/AMDGPU/dag-combine-brcond.ll:10
+; GCN:   s_cbranch_vccz BB0_4
+define amdgpu_kernel void @test(float addrspace(1)* %arg1) {
+bb:
----------------
Can't this be reduced further?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55030/new/

https://reviews.llvm.org/D55030





More information about the llvm-commits mailing list