[PATCH] D54891: [RFC] Checking inline assembly for validity

Wed Nov 28 23:57:01 PST 2018

glandium added a comment.

In D54891#1311086 <https://reviews.llvm.org/D54891#1311086>, @olista01 wrote:

> > I can provide a full log of the 4831 warnings marked -Winline-asm during a Firefox for ARM Android build, if you're interested.
>
> Yes, it would be helpful if you could send me that output (with the latest patch applied).

I extracted the warnings from the log and processed them to link to the corresponding code:
https://glandium.org/files/llvm-D54891-log-20181129.html

There are much less warnings with the new patch than before. And there are some interesting things in there. Like cases where the assembly pushes a register value to the stack, does stuff with it, and restores it ; with no annotation, and I think it's right doing so.

(Note that the code that was built has both fixes I linked earlier reverted, which is why the mpi_arm.c code is full of warnings ; I should do another run with the fix re-applied.)

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54891/new/

https://reviews.llvm.org/D54891