[PATCH] D54713: [SCEV] Guard movement of insertion point for loop-invariants

[Serguei Katkov via Phabricator via llvm-commits]

skatkov accepted this revision.
skatkov added a comment.
This revision is now accepted and ready to land.

LGTM. If Max or Sanjoy does not object in a, say, one day, feel free to land.



================
Comment at: llvm/lib/Analysis/ScalarEvolutionExpander.cpp:1765
+          InsertPt = &*L->getHeader()->getFirstInsertionPt();
+        }
+      } else {
----------------
you can remove {}


================
Comment at: llvm/lib/Analysis/ScalarEvolutionExpander.cpp:1776
+          InsertPt = &*std::next(InsertPt->getIterator());
+        }
+        break;
----------------
you can remove {}. I know it is not your code but probably makes sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54713/new/

https://reviews.llvm.org/D54713