[PATCH] D53051: [llvm-tapi] initial commit, supports ELF text stubs

Armando Montanez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 28 17:42:22 PST 2018


amontanez added inline comments.


================
Comment at: llvm/include/llvm/TextAPI/ELF/ELFStub.h:63
+  /// Sorts all symbols by name in ascending order.
+  void sortSymbolsByName();
+};
----------------
ruiu wrote:
> Instead of providing this function, you could make `Symbols`s type to `std::set` which is a sorted set.
Unfortunately std::set doesn't allow in-place modification of elements, so it won't work with YAML. I'll look into alternative options.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53051/new/

https://reviews.llvm.org/D53051





More information about the llvm-commits mailing list