[PATCH] D52822: [llvm-readobj][AMDGPU] Moved AMDGPU-specific note record dumping into target
Saleem Abdulrasool via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 28 13:47:14 PST 2018
abdulras requested changes to this revision.
abdulras added a comment.
This revision now requires changes to proceed.
I don't mind the separation, but, I don't see what makes this target specific still. I really think that we should have this be out-side of the target specific content, but having this in LLVM instead of the `readobj` tool makes sense. At the very least, I think that we need to fix the big endian case.
================
Comment at: lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp:951
+ // llvm-readobj on a big-endian host.
+#if BYTE_ORDER == LITTLE_ENDIAN
+ OS << "NT_AMD_AMDGPU_PAL_METADATA (PAL Metadata)\n";
----------------
You should be able to use `ulittle_*` to decode this even on a big endian host. I don't see why the content being in little endian should prevent the host tools from running on big endian.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D52822/new/
https://reviews.llvm.org/D52822
More information about the llvm-commits
mailing list