[PATCH] D54982: [WebAssembly] Update docs
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 28 11:30:43 PST 2018
ruiu added inline comments.
================
Comment at: docs/WebAssembly.rst:48
+
+ When building a executable, export any non-hidden symbols. By default only
+ the entry point and any symbols marked with --export/--export-all are
----------------
a -> an
================
Comment at: docs/WebAssembly.rst:54
+
+ Address at which to place global data
+
----------------
Add a full stop.
================
Comment at: docs/WebAssembly.rst:58
+
+ Disble merging of data segments.
+
----------------
Disable
================
Comment at: docs/WebAssembly.rst:62
+
+ Place stack at start of linear memory rather than after data
+
----------------
Full stop.
================
Comment at: docs/WebAssembly.rst:66
+
+ Compress the relocation targets in the code section.
+
----------------
This might be too brief. I'd also mention that this option should be used when you are creating a release version of a binary.
================
Comment at: docs/WebAssembly.rst:70
+
+ Allow undefined symbols in linked binary
+
----------------
Full stop. I think you should mention that this is mostly for debugging and should not be used for a release version of binary.
================
Comment at: docs/WebAssembly.rst:74
+
+ Import memory from the environment
+
----------------
Full stop.
================
Comment at: docs/WebAssembly.rst:78
+
+ Initial size of the linear memory. Default: static data size
+
----------------
Full stop.
================
Comment at: docs/WebAssembly.rst:93
+Since WebAssembly is designed with size in mind the linker defaults to
+``--gc-sections`` which means that all un-used functions and data segments will
+be stripped from the binary.
----------------
un-used -> unused
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54982/new/
https://reviews.llvm.org/D54982
More information about the llvm-commits
mailing list