[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

[Davide Italiano via Phabricator via llvm-commits]

davide added a comment.

I reverted this change because it breaks a bunch of lldb tests (on MacOS, and probably on other platforms too).
To be clear, part of the reason I'm reacting strongly here is that this is not the first patch this has come up on. 
 I'm worried about the broader trend of landing patches to ASTImporter without proper reviews and testing as I am of this very instance. 
I really think you should consider asking reviews to somebody who's familiar with clang and test lldb as it's the main client of this functionality we have in tree.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53818/new/

https://reviews.llvm.org/D53818