[PATCH] D54984: [X86] Make X86TTIImpl::getCastInstrCost properly handle the case where AVX512 is enabled, but 512-bit vectors aren't legal.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 28 06:55:32 PST 2018


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Target/X86/X86TargetTransformInfo.cpp:1555
+
+  // Support make sure that neither type is going to be split before using the
+  // AVX512F tables. This handles -mprefer-vector-width=256
----------------
Remove "Support"?


================
Comment at: lib/Target/X86/X86TargetTransformInfo.cpp:1562-1563
+      if (const auto *Entry = ConvertCostTableLookup(AVX512DQConversionTbl, ISD,
+                                                     SimpleDstTy,
+                                                     SimpleSrcTy))
+        return Entry->Cost;
----------------
can squeeze these onto 1 line now...yay, 80-cols!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54984/new/

https://reviews.llvm.org/D54984





More information about the llvm-commits mailing list