[PATCH] D54994: [simplifycfg][NFC] add tests for cross block compare instructions fold and optimization.

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/test/Transforms/SimplifyCFG/branch-fold-three.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -simplifycfg -instcombine -simplifycfg -S | FileCheck %s
+; s >= t, s != t, s <= t
----------------
This should only be testing with a single -simplifycfg.
If there's a cross-pass dependency that you want to confirm is resolved, then you probably want to add a test to 
test/Transforms/PhaseOrdering, but ideally, we will show the key transform using just a single pass.


================
Comment at: llvm/test/Transforms/SimplifyCFG/branch-fold-three.ll:4
+; s >= t, s != t, s <= t
+define void @_Z4foo1ii(i32 signext %s, i32 signext %t) #0 {
+; CHECK-LABEL: @_Z4foo1ii(
----------------
You can remove the empty #0/#1 attribute specifiers.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54994/new/

https://reviews.llvm.org/D54994