[PATCH] D54743: SROA: preserve alignment tags on loads and stores.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 28 06:26:36 PST 2018


lebedev.ri added a comment.

Maybe explicitly add reviewers?
`git diff --name-only --cached | xargs -n 1 git blame --porcelain | grep  "^author " | sort | uniq -c | sort -nr | head -10`

Looks ok to me, but i'm not familiar with this code.



================
Comment at: llvm/lib/Transforms/Scalar/SROA.cpp:3228-3229
+
     /// Initialize the splitter with an insertion point, Ptr and start with a
     /// single zero GEP index.
+    OpSplitter(Instruction *InsertionPoint, Value *Ptr, Type *BaseTy,
----------------
Outdated comment?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54743/new/

https://reviews.llvm.org/D54743





More information about the llvm-commits mailing list