[PATCH] D54624: [LLD][ELF] Error if _GLOBAL_OFFSET_TABLE_ is defined in input objects

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Writer.cpp:222
+      error("cannot redefine linker defined symbol _GLOBAL_OFFSET_TABLE_\n"
+            "definition in: " + toString(S->File));
+    else
----------------
I think you should use the `GotTableSymName` here? (for EM_PPC64 case)

Also, we often print the location first,
so I would suggest printing something like:
```
toString(S->File) + ": cannot redefine linker defined symbol '" + GotTableSymName + "'";
``` 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54624/new/

https://reviews.llvm.org/D54624