[PATCH] D54891: [RFC] Checking inline assembly for validity

[Oliver Stannard via Phabricator via llvm-commits]

olista01 added a comment.

mpi_arm.c:

- For the warnings which are emitted, some register MCOperands are being matched against the wrong parsed operand.
- For post-increment instructions, the assembly matcher is not setting the writeback register in the MCInst (leaving it as noreg), because it is tied to one part of a complex operand, which it doesn't support. The fix for this might be to make a similar change to rL209425 <https://reviews.llvm.org/rL209425> in the ARM backend, which would give other advantages (better diagnostics for memory operands).

ttinterp.c:

- The caret on the "instantiated into assembly here" is the accurate one (pointing to the mov instruction after the smull), the mapping back to C/C++ source locations isn't currently accurate. Improving that is on my TODO list, but I haven't looked into it yet.
- There are ~10 t2AsmPseudo records in the Thumb2 tablegen file which have every operand marked as input, this looks like a simple fix. I expect we'll uncover more issues like this, because we are using information which hasn't been used for anything in the MC library before.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54891/new/

https://reviews.llvm.org/D54891