[PATCH] D54985: [ELF] Keep empty In.RelaIplt so that __rela_iplt_{start, end} have valid st_shndx

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 27 18:31:45 PST 2018


MaskRay added a comment.

In D54985#1310779 <https://reviews.llvm.org/D54985#1310779>, @emaste wrote:

> This is fine for me (from FreeBSD's perspective), but I suspect some people (on operating systems without ifuncs in libc) may be surprised by having a(n empty) .rela.plt in all of their statically linked binaries.


Also read my comment https://bugs.llvm.org/show_bug.cgi?id=36634#c3 This makes most sense to me but it requires lots of changes and I haven't investigated how valid it is to have such empty ALLOC sections (and in the segment end but it probably does not matter)


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54985/new/

https://reviews.llvm.org/D54985





More information about the llvm-commits mailing list