[PATCH] D54873: [WebAssembly] Make signature index not a part of EventType

[Derek Schuff via Phabricator via llvm-commits]

dschuff added inline comments.


================
Comment at: include/llvm/BinaryFormat/Wasm.h:85
 
 struct WasmEventType {
   // Kind of event. Currently only WASM_EVENT_ATTRIBUTE_EXCEPTION is possible.
----------------
Now that this structure no longer directly reflects the binary format, it might make sense to just remove it since there's no need for a 1-element structure. I still think that `FooKind` -style nomenclature like that used elsewhere in LLVM is more readable (since this models "kinds" of events, one of which is exception). I actually think I'd like to rename `attribute` to `kind` in the spec itself, but that's obviously a separate thing.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54873/new/

https://reviews.llvm.org/D54873