[PATCH] D54933: Fix bugs in SmallBitVector

Brad Moody via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 27 16:30:57 PST 2018


bmoody updated this revision to Diff 175596.
bmoody edited the summary of this revision.
bmoody added a comment.

New diff that makes SmallBitVector::isSmall() public and adds asserts to the tests.

I don't really agree with this change because I don't think isSmall should be part of SmallBitVector's public interface and I think the test is explicit enough without the asserts.  But it's here if you want it.

P.s. I don't have commit access, so you're welcome to make any final tweaks and commit on my behalf.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54933/new/

https://reviews.llvm.org/D54933

Files:
  include/llvm/ADT/SmallBitVector.h
  unittests/ADT/BitVectorTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54933.175596.patch
Type: text/x-patch
Size: 10679 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181128/da625554/attachment.bin>


More information about the llvm-commits mailing list