[PATCH] D54472: Disable invalid isPodLike<> specialization

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

(honestly, I think I've lost the thread on this - between the reviews to define a trivially copyable attribute (not your work, but it's happened around the same time/recently - Arther O'Dwyer's D50119 <https://reviews.llvm.org/D50119> phab review), these changes, the different aspects for different compilers, the different design choices/iterations this has gone through, the different classes that need to be handled or functionality dropped, etc)

Might benefit from a current summary?

and/or might be better to separate these in some way - eg: for the obvious/easy cases where removing the isPodLike specialization is benign because is_trivially_copyable already does the right thing, those should be easy - they don't regress functionality, they work with the existing implementation, or any newer/narrower implementation, etc?

Is the patch description up to date anymore? It doesn't look like it describes the Optional changes as they are now (doesn't look like they revert r347004 currently - and if they did that'd require some care/attention to address the reasons r347004 was committed in the first place), but I'm not sure.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54472/new/

https://reviews.llvm.org/D54472