[PATCH] D54968: [ELF] --gdb-index: use const char *, uint32_t to replace CachedHashStringRef

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 27 15:50:34 PST 2018


MaskRay added a comment.

- For clang, the total number of `NameAttrs` is 32496
- For an internal larger executable, it is 193776

I think both memory/space changes are negligible (I made a mistake when giving the statistics "4.8 seconds (4.884600870 seconds time elapsed) while with the patch, it is usually 4.7": used a wrong `ld.lld`).


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54968/new/

https://reviews.llvm.org/D54968





More information about the llvm-commits mailing list