[PATCH] D54917: [ELF] Delete TargetInfo::getPltEntryOffset and simplify Symbol::getPltVA

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 27 15:29:29 PST 2018


ruiu added a comment.

I see your point, and I agree with that. But the new code is also error-prone because you can make a mistake to not to add the header size, for example. So not sure which is better.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54917/new/

https://reviews.llvm.org/D54917





More information about the llvm-commits mailing list