[PATCH] D54873: [WebAssembly] Make signature index not a part of EventType
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 27 14:52:31 PST 2018
sbc100 added inline comments.
================
Comment at: include/llvm/BinaryFormat/Wasm.h:88
uint32_t Attribute;
- uint32_t SigIndex;
};
----------------
My initial reaction is that we should leave this as is.
The linker shouldn't be modifying the input EventTypes but instead creating a new set of output eventtypes based on the input ones. At least that how it makes sense to me. I will take a look at the lld side change and see if I can make some suggestions there.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54873/new/
https://reviews.llvm.org/D54873
More information about the llvm-commits
mailing list