[PATCH] D54674: [llvm-objcopy] First bits for MachO

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added a comment.

In D54674#1303281 <https://reviews.llvm.org/D54674#1303281>, @alexshap wrote:

> also, @jakehehrlich, @jhenderson, @rupprecht  - what would you say to moving the existing tests  (llvm/test/tools/llvm-objcopy) into the subfolder ELF (llvm/test/tools/llvm-objcopy/ELF) ? if it's ok - i can do that on a separate diff.


Sounds like a good idea to me, as long as "ninja check-llvm-tools-llvm-objcopy" will still run both ELF and MachO tests. Agreed that it doesn't have to happen in this commit.



================
Comment at: test/tools/llvm-objcopy/MachO/basic-big-endian-32-copy.test:4
+# RUN: cmp %t %t2
+# RUN: obj2yaml %t2 | FileCheck %s
+
----------------
The existing ELF tests use llvm-readobj instead of obj2yaml to verify things, is it possible to use that for MachO as well?


================
Comment at: test/tools/llvm-objcopy/MachO/basic-big-endian-32-copy.test:116
+# CHECK: --- !mach-o
+# CHECK: FileHeader:
+# CHECK:  magic:           0xFEEDFACE
----------------
Can you also verify things coming from sections/symbol tables/etc? It seems this only tests that the FileHeader is preserved and everything else could be dropped...


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54674/new/

https://reviews.llvm.org/D54674