[PATCH] D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

In D40147#1309748 <https://reviews.llvm.org/D40147#1309748>, @atanasyan wrote:

> In D40147#1308904 <https://reviews.llvm.org/D40147#1308904>, @ruiu wrote:
>
> > Adding a new parameter to `relocateOne` doesn't look beautiful, but that makes me think whether you are editing the right place of the code. `relocateOne` is supposed to apply a single relocation based on a value passed to the function. No complex logic should be in the function. Passing one more parameter so that you can do more complex computation in the function may not be a good idea.
>
>
> That's interesting - you suggested to pass a `Symbol` to `relocateOne` on Feb 16.
>  https://reviews.llvm.org/D40147#inline-379274
>
> I will try to implement an alternative solution. Maybe by updating one of initial patches.


Yeah, sorry, but until code is actually written, I don't know whether it is going to look good or not, so I can suggest, but my suggestion is not a promise or anything.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D40147/new/

https://reviews.llvm.org/D40147