[PATCH] D54967: [OPENMP][NVPTX]Basic support for reductions across the teams.

[Kelvin Li via Phabricator via llvm-commits]

kkwli0 added inline comments.


================
Comment at: libomptarget/deviceRTLs/nvptx/src/reduction.cu:435
+EXTERN int32_t __kmpc_nvptx_teams_reduce_nowait_simple(kmp_Ident *loc,
+                                                       int32_t global_tid,
+                                                       kmp_CriticalName *crit) {
----------------
Why is `global_tid` being passed in but not used?


================
Comment at: libomptarget/deviceRTLs/nvptx/src/reduction.cu:446
+EXTERN void
+__kmpc_nvptx_teams_end_reduce_nowait_simple(kmp_Ident *loc, int32_t global_tid,
+                                            kmp_CriticalName *crit) {
----------------
Same as above, `loc` and `global_tid` are not used in the routine?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54967/new/

https://reviews.llvm.org/D54967