[PATCH] D54968: [ELF] --gdb-index: use const char *, uint32_t to replace CachedHashStringRef

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

I believe the memory savings of this patch is not free; it now has to scan the same string more than once to find a null terminator. Even though we want to reduce memory usage of lld for Google, in general, saving memory is not always the goal that we want to achieve. We need to get a right balance. To do that, can you tell me how much memory you can save with this patch, and how much is the performance penalty of this patch?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54968/new/

https://reviews.llvm.org/D54968