[PATCH] D54917: [ELF] Comment about retpoline IPLT in getPltVA
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 27 13:05:56 PST 2018
MaskRay added a comment.
In D54917#1310018 <https://reviews.llvm.org/D54917#1310018>, @ruiu wrote:
> I mean we probably should set `PltHeaderSize` to 0 if IPLT because IPLT's header size is actually zero (unless it is a retpoline IPLT, in which case it should be set to an appropriate value.)
`TargetInfo::PltHeaderSize` is a field of `TargetInfo`, not `PltSection`. I cannot set `PltHeaderSize` to 0 for IPLT because otherwise when both normal PLT and IPLT are used, the `PltHeaderSize` of the normal PLT would be incorrect (0).
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54917/new/
https://reviews.llvm.org/D54917
More information about the llvm-commits
mailing list