[PATCH] D54917: [ELF] Comment about retpoline IPLT in getPltVA

Tue Nov 27 12:56:13 PST 2018

MaskRay added a comment.

In D54917#1310010 <https://reviews.llvm.org/D54917#1310010>, @ruiu wrote:

> Now I think it is more clear than before that adding the size of the header in `getPltVA` is weird. Maybe that should be handled in `getPltEntryOffset` that's where we should compute an offset for an PLT entry. Also, please don't casually add an optional parameter to an existing function to "tweak" existing behavior in a subtle way. That kind of changes can quickly accumulate and make functions really hard to understand.

`TargetInfo::getPltEntryOffset` does not know which PLT section (normal PLT or IPLT) the caller is referring to.

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54917/new/

https://reviews.llvm.org/D54917