[PATCH] D54963: [lit] Pass more environment variables through on Windows

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 27 11:23:00 PST 2018


zturner added a comment.

I don't think that ever actually happened, or at least I never observed it.  The real behavior change is that we're now passing through "LIB", "VCINSTALLDIR", "VCToolsInstallDir", "VSINSTALLDIR", "WindowsSdkDir", and "WindowsSdkVersion", whereas before we were not propagating them into the child environment at all.  clang-cl reads these, so it could have an observable impact on clang-cl (but any observable impact should be beneficial, since before it would actually just fail if a test tried to include a system header or link against a system library)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54963/new/

https://reviews.llvm.org/D54963





More information about the llvm-commits mailing list