[PATCH] D54917: [ELF] Comment about retpoline IPLT in getPltVA
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 27 10:19:42 PST 2018
ruiu added a comment.
Now I think it is more clear than before that adding the size of the header in `getPltVA` is weird. Maybe that should be handled in `getPltEntryOffset` that's where we should compute an offset for an PLT entry. Also, please don't casually add an optional parameter to an existing function to "tweak" existing behavior in a subtle way. That kind of changes can quickly accumulate and make functions really hard to understand.
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54917/new/
https://reviews.llvm.org/D54917
More information about the llvm-commits
mailing list