[PATCH] D53629: [GlobalISel] Restrict G_MERGE_VALUES capability and replace with new opcodes

[Volkan Keles via Phabricator via llvm-commits]

volkan added a comment.

In D53629#1309860 <https://reviews.llvm.org/D53629#1309860>, @qcolombet wrote:

> Hi Volkan,
>
> > We are unable to legalize the test below because of the missing combine.
>
> This sentence jumped at me. Are you saying we have mandatory combines at this point for legalization to work?
>  Although that wouldn't surprise me, I would like we have a clear list of what they are (if that's not already the case.)
>
> Cheers,
> -Quentin


Hi Quentin,

It's not required for legalization, the target should handle that operation without depending on the artifact combiner.
I meant we should handle G_BUILD_VECTOR to avoid regressions as we are able to legalize the same function with G_MERGE_VALUES.

Volkan


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53629/new/

https://reviews.llvm.org/D53629