[PATCH] D54619: [ELF] - Refactor getRelocTargetVA(). NFC.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 27 09:08:59 PST 2018


ruiu added a comment.

Honestly I don't think the new code is better than the existing one. All target-specific relocation types are clearly prefixed with target names (e.g. R_AARCH64 or R_HEXAGON), and I kind of like the old code as it is just a flat switch-case list.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54619/new/

https://reviews.llvm.org/D54619





More information about the llvm-commits mailing list