[PATCH] D54904: Introduce `AddressSpaceView` template parameter to `SizeClassAllocator32`, `FlatByteMap`, and `TwoLevelByteMap`.

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek added a comment.

The patch is quite big. I've added a couple suggestions how to reduce it to make it easier to review.



================
Comment at: lib/sanitizer_common/sanitizer_allocator.h:25
 #include "sanitizer_procmaps.h"
+#include "sanitizer_type_traits.h"
 
----------------
Also remove.


================
Comment at: lib/sanitizer_common/sanitizer_allocator_primary32.h:112-114
+    static_assert(
+        is_same<typename ByteMap::AddressSpaceView, AddressSpaceView>::value,
+        "AddressSpaceView type mismatch");
----------------
Also remove.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54904/new/

https://reviews.llvm.org/D54904