[PATCH] D54769: [FileCheck] New option -warn

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D54769#1309552 <https://reviews.llvm.org/D54769#1309552>, @jdenny wrote:

> Both diagnostics we have been discussing can frustrate attempts to comment directives. There are ways to work around both: temporarily change the preceding CHECK-LABEL to CHECK, or remove the associated prefix from the FileCheck command.
>
> Alternatively, if diagnostics tell you their names (just as compiler warnings do), you could temporarily use the -diags=no-DIAG option I proposed. But that means leaving that option available indefinitely... but maybe that'll be necessary anyway once we have investigated all the test suites.


I accidentally submitted that comment before I was done editing.  I fixed it, but it looks like no email notification was sent for the edit.

Anyway, another thought: maybe it's time for a true comment directive, which would be used something like this:

  // CHECK-COMMENT: CHECK: pattern

First, the intention is far clearer than

  // XHECK: pattern

and so should probably always be used for commenting out directives going forward.  Moreover, it could also suppress diagnostics.  That is, for the sake of these diagnostics, it could either (1) be considered to be, or (2) be checked to contain a non-LABEL directive of the relevant prefix.

This directive could be a separate patch, and it could be pushed later provided it's pushed before these diagnostics are enabled by default.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54769/new/

https://reviews.llvm.org/D54769