[PATCH] D54877: Update coding guidelines regarding use of `auto`
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 27 06:52:00 PST 2018
asb added inline comments.
================
Comment at: docs/CodingStandards.rst:795-796
+* With initializers like ``cast<Foo>(...)``.
+* Where the variable names makes it clear what it is for,
+ such as ``auto it`` instead of ``std::vector<T>::iterator it``.
+* Range-based for loops.
----------------
This is a change in justification vs the previous wording, and I think the previous justification is more compelling. "the type would have been abstracted away anayways, often behind a container's typedef such as ``std::vector<T>::iterator``"
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54877/new/
https://reviews.llvm.org/D54877
More information about the llvm-commits
mailing list