[PATCH] D54624: [LLD][ELF] Error if _GLOBAL_OFFSET_TABLE_ is defined in input objects
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 27 03:07:10 PST 2018
grimar added inline comments.
================
Comment at: ELF/Writer.cpp:220
+ if (Symtab->find(GotTableSymName))
+ ElfSym::GlobalOffsetTable = (Symtab->addDefined(
+ GotTableSymName, STV_HIDDEN, STT_NOTYPE, Target->GotBaseSymOff,
----------------
You do not need the bracers around the right side of the expression it seems:
```
ElfSym::GlobalOffsetTable = Symtab->addDefined(
GotTableSymName, STV_HIDDEN, STT_NOTYPE, Target->GotBaseSymOff,
/*Size=*/0, STB_GLOBAL, Out::ElfHeader,
/*File=*/nullptr);
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54624/new/
https://reviews.llvm.org/D54624
More information about the llvm-commits
mailing list