[PATCH] D54933: Fix bugs in SmallBitVector

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 26 23:33:18 PST 2018


dexonsmith added inline comments.


================
Comment at: unittests/ADT/BitVectorTest.cpp:237
   // Also test with a vector that is small enough to fit in 1 word.
+  A.clear();
   A.resize(20);
----------------
It's not locally obvious why this `clear()` is important.  Is it cleaner to just split into a separate test?  Is there also an `ASSERT_*` you can add to prove that it's in small mode?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54933/new/

https://reviews.llvm.org/D54933





More information about the llvm-commits mailing list