[PATCH] D54883: [Support/FileSystem] Use st_atimespec only when __APPLE__ is defined

[Michał Górny via Phabricator via llvm-commits]

mgorny added a comment.

1. Wrong. Specific checks are easier to find and remove because they can be easily found. Looking for `__APPLE__` is going to yield much more results than anticipated.
2. Expecting people to fix old releases because your fragile logic stopped working and they need the old version for some project is not nice.

Portability is about writing code that's portable **right now**, i.e. can work on many platforms, including platforms you didn't specifically anticipate. It's not only about specifically accounting for the platforms you care about, and deferring fixing the rest on somebody else. Or claiming that somebody's platform doesn't have to be supported because he doesn't have resources to contribute a buildbot.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54883/new/

https://reviews.llvm.org/D54883