[PATCH] D54137: AArch64: Fix invalid CCMP emission
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 26 23:03:42 PST 2018
mstorsjo added a subscriber: tstellar.
mstorsjo added a comment.
In D54137#1293804 <https://reviews.llvm.org/D54137#1293804>, @MatzeB wrote:
> Maybe you can give it at least some cursory review?
>
> Adding some more reviewers who were active in AArch64ISelLowering recently.
>
> > Or is @MatzeB confident enough in the change as is?
> > Also, should we try to get this, together with the preceding refactoring, into 7.0.1?
>
> I feel confident that this code is bettter than before. And I would also recommend pushing it for 7.0.1 (if we had it on the buildbots for a couple days) considering that it fixes a miscompile in "normal" code.
@tstellar FYI, there's interest in getting this in for 7.0.1, but it's still pending @MatzeB's response to @efriedma's comments. But of course, I understand that if it doesn't make the merge request deadline, then it'll have to be skipped.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54137/new/
https://reviews.llvm.org/D54137
More information about the llvm-commits
mailing list