[PATCH] D54930: [gn build] Add a script to check if source lists in BUILD.gn files and CMakeLists.txt files match.

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 26 22:21:08 PST 2018


thakis created this revision.
thakis added a reviewer: phosek.
Herald added subscribers: hiraditya, mgorny.

Also fix a missing file in lib/Support/BUILD.gn found by the script.

The script is very stupid and assumes that CMakeLists.txt follow the standard LLVM CMakeLists.txt formatting with one cpp source file per line. Despite its simplicity, it works well in practice.

It would be nice if it also checked deps and maybe automatically applied its suggestions.


https://reviews.llvm.org/D54930

Files:
  llvm/utils/gn/README.rst
  llvm/utils/gn/build/sync_source_lists_from_cmake.py
  llvm/utils/gn/secondary/llvm/lib/Support/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54930.175400.patch
Type: text/x-patch
Size: 3651 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181127/3befb30d/attachment.bin>


More information about the llvm-commits mailing list