[PATCH] D54678: [gn build] Create abi-breaking.h, config.h, llvm-config.h, and add a build file for llvm/lib/Support.

[Nico Weber via Phabricator via llvm-commits]

thakis marked 4 inline comments as done.
thakis added a comment.

Thanks! Landing.



================
Comment at: llvm/utils/gn/secondary/llvm/lib/Target/targets.gni:34
+  # FIXME: Port the remaining targets.
+  assert(target == "AArch64" || target == "ARM" || target == "X86",
+         "Unknown target '$target'.")
----------------
phosek wrote:
> Move this assert into an `else` branch below? That way you don't have repeat all targets here and in the `if` conditions below.
Much nicer, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54678/new/

https://reviews.llvm.org/D54678