[PATCH] D54877: Update coding guidelines regarding use of `auto`
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 26 20:35:17 PST 2018
mehdi_amini added a comment.
In D54877#1309017 <https://reviews.llvm.org/D54877#1309017>, @zturner wrote:
> In D54877#1308855 <https://reviews.llvm.org/D54877#1308855>, @zturner wrote:
>
> >
>
>
> at the end of the day, comments that arise in code review should take precedence over what the style guide does or doesn't say when it concerns readability, since it's an actual account of someone stating that they do or don't find something readable, and that's what we're trying to optimize for.
FWIW as another data point: I have a totally opposed view on the subject: I rather have clear guidelines *when possible*. Otherwise it is the realm of inconsistency and instability: one reviewers makes you change towards a prefered idiom while the next reviewer will prefer another one.
Just because like you wrote before (with a twist): " because there is only 1 of this reviewers and there are many other people".
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54877/new/
https://reviews.llvm.org/D54877
More information about the llvm-commits
mailing list