[PATCH] D54802: [LLD][COFF] Generate import modules in PDB
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 26 18:51:33 PST 2018
pcc added inline comments.
================
Comment at: lld/trunk/COFF/Driver.cpp:1226
// precedence, but we will emit a warning if there is a conflict.
- parseMerge(".idata=.rdata");
parseMerge(".didat=.rdata");
----------------
rnk wrote:
> Do you want to submit this separately? It seems to cause wide ranging mechanical changes to the tests. Feel free to submit it without review.
Are you sure that this is what link.exe does? I'm pretty sure I added this here after noticing that this was what link.exe did, see D45737
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54802/new/
https://reviews.llvm.org/D54802
More information about the llvm-commits
mailing list